fix(cli): make loader async to make it spin #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexxeln
requested review from
juliusmarminge,
t3dotgg and
c-ehrlich
as code owners
🦋 Changeset detectedLatest commit: f9f72ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-nexxel-fix-loader-t3-oss.vercel.app/ |
juliusmarminge
added
🚀 autorelease
|
A new create-t3-app prerelease is available for testing. You can install this latest build in your project with: |
|
Beautiful |
juliusmarminge
approved these changes
Oct 15, 2022
|
git step is messed up, will make that async too ig |
juliusmarminge
added
🚀 autorelease
|
didn't fix 😢 |
|
Good enough for now i guess. Should fix the duplicate Git prompt though |
juliusmarminge
approved these changes
Oct 16, 2022
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #610
✅ Checklist
Changelog
Installde
execato exec loader asynchronously.