Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vercel): add screenshots for vercel guide #524

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

nexxeln
Copy link
Member

@nexxeln nexxeln commented Sep 30, 2022

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-08-15).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

The vercel guide looked kinda sad so I added some screenshots


@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2022

⚠️ No Changeset found

Latest commit: 78704e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 10:48AM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Sep 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 96
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-nexxel-vercel-t3-oss.vercel.app/

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we dump all screenshots into /public/images or does it make sense to start some kind of structure (folders that match the table of contents items or whatever)?

@nexxeln
Copy link
Member Author

nexxeln commented Sep 30, 2022

Should we dump all screenshots into /public/images or does it make sense to start some kind of structure (folders that match the table of contents items or whatever)?

I don't think there's a need to do this right now. But when we have a lot of images we can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants