Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): avoids big code blocks #407

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

marlalain
Copy link
Contributor

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-08-15).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Moves some big blocks of code to functions, so the main function can be clearer/easier to read.

💯

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

⚠️ No Changeset found

Latest commit: f1999eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 6:33PM (UTC)

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good change.

Also seems like you "missed" the name-part.

cli/src/cli/index.ts Outdated Show resolved Hide resolved
cli/src/cli/index.ts Outdated Show resolved Hide resolved
cli/src/cli/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Julius Marminge <[email protected]>
@juliusmarminge
Copy link
Member

Also seems like you "missed" the name-part.

Bring that out to a separate function too for coherency

@marlalain
Copy link
Contributor Author

Oh that's what you meant. Sure

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Since this logic isn't caught by CI I suggest we do some manual tests to be sure before merging.

@c-ehrlich
Copy link
Member

behaves correctly both with and without name provided to the cli

image

@marlalain
Copy link
Contributor Author

marlalain commented Sep 8, 2022

I retested before pushing too

@juliusmarminge
Copy link
Member

Cool I'll merge, we can test @beta afterwards

@juliusmarminge juliusmarminge merged commit a7c2b19 into t3-oss:next Sep 8, 2022
@marlalain marlalain deleted the ref/big-code-block branch September 8, 2022 19:05
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants