Feat: windows build support, more readme instructions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
works for me in windows though, @nexxeln thoughts? |
Are you using windows WSL w/ ubuntu maybe? |
nexxeln
requested changes
Jun 22, 2022
nexxeln
requested changes
Jun 22, 2022
README.md
Outdated
Comment on lines
39
to
42
| To start the package locally on mac/linux | ||
| ```bash | ||
| npm start | ||
| ``` |
There was a problem hiding this comment.
To start the CLI locally on mac/linux
pnpm start
README.md
Outdated
Comment on lines
44
to
47
| To start the package on windows: | ||
| ```bash | ||
| npm start-w | ||
| ``` |
There was a problem hiding this comment.
To start the package on windows:
pnpm start-w
nexxeln
approved these changes
Jun 22, 2022
|
Thank you! |
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
Feat: windows build support, more readme instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for windows by adding another script in package.json, this error popped up when trying to build:
I added some instructions in the readme so it's easier for new people to start contributing.