refactor: perf gains #260
refactor: perf gains #260
Conversation
|
Correct branch this time |
| pkgManager === "npm" | ||
| ? "npx prisma generate" | ||
| : `${pkgManager} prisma generate`; | ||
| await execa(generateClientCmd, { cwd: projectDir }); |
There was a problem hiding this comment.
this will be executed in post install script anyway so no need to run it here too
| export const dependencyVersionMap = { | ||
| // NextAuth.js | ||
| "next-auth": "^4.10.2", | ||
| "@next-auth/prisma-adapter": "^1.0.4", | ||
|
|
||
| // Prisma | ||
| prisma: "^4.1.0", | ||
| "@prisma/client": "^4.1.0", | ||
|
|
||
| // TailwindCSS | ||
| tailwindcss: "^3.1.6", | ||
| autoprefixer: "^10.4.7", | ||
| postcss: "^8.4.14", | ||
|
|
||
| // tRPC | ||
| "@trpc/client": "10.0.0-alpha.41", | ||
| "@trpc/server": "10.0.0-alpha.41", | ||
| "@trpc/react": "10.0.0-alpha.41", | ||
| "@trpc/next": "10.0.0-alpha.41", | ||
| "react-query": "^3.39.2", | ||
| superjson: "^1.9.1", | ||
| } as const; |
Yes changing "fs.async" -> "fs.sync" made some difference (about 5 seconds I think), I read that in some cases it can be upto 6-7 times faster... Example test: https://adamhooper.medium.com/node-synchronous-code-runs-faster-than-asynchronous-code-b0553d5cf54e but there are others showing simliar results Then by just adding the dependency to package.json and running a single |
Makes sense, so is this ready to be merged? We can test it out in beta. |
I targetted next but maybe we can publish beta from there? |
|
Sure |
Improve CLI Performance
Scaffolding a full T3 app can take time. This aims to reduce that time.
For initialization stuff like we do, fs.copySync() is faster than fs.copy() etc. (from what I've read you should only use async version on server stuff when needing cpu power for other stuff)
So I have refactored to take advantage of this. By using sync over async I decreased scaffolding times on my machine from 32 to 28 seconds for a full app.
I also refactored so that we only run a single npm install command at the end, instead of running 5-10 per app.
Might be more things we can do to further decrease scaffolding time?
Screenshots
[Screenshots]
💯