Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes drizzle db push command #1888

Closed
wants to merge 2 commits into from

Conversation

gcjbr
Copy link
Contributor

@gcjbr gcjbr commented May 12, 2024

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

💯

Copy link

changeset-bot bot commented May 12, 2024

⚠️ No Changeset found

Latest commit: 90daf1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 11:51pm

Copy link

vercel bot commented May 12, 2024

@gcjbr is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@juliusmarminge
Copy link
Member

this doesn't fix anything does it? it's just stylistic?

@gcjbr
Copy link
Contributor Author

gcjbr commented May 17, 2024

this doesn't fix anything does it? it's just stylistic?

It does, if we try to drizzle-kit push with the version of drizzle-kit we updated on another PR it's gonna scream at us.

@juliusmarminge
Copy link
Member

Hey, Thanks for the PR.

This change was incorporated in #1893 which also added some other stuff, so I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants