Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start-database.sh CONTAINER_NAME update with '.' project name (#1834) #1871

Merged
merged 2 commits into from
May 7, 2024

Conversation

xelacast
Copy link
Contributor

@xelacast xelacast commented May 7, 2024

Closes #1834

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

NOTE: I was messing with my forked repo and accidentally closed the original pr because of a rebase of the main branch.

The dbContainer.ts file in cli/src/installers/dbContainer.ts was updated with a parseNameAndPath function when a projectName of "." was used. This was done with a ternary and destructuring to keep the type safety of the variable.

I had a few options.

  1. I could change the start-database.sh script to check for "." project names and change accordingly
  2. I could change the file that was changing the start-database.sh file
    I decided to go with the last route because it's a single source of truth and can be used for future implementations.

I followed the data flow of projectName and scopedProjectName through and through and couldn't find a solution.
Then I tried a few other things to see If I could make this feel less hacky but to no avail.

Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 4acab1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:18am

Copy link

vercel bot commented May 7, 2024

@xelacast is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@juliusmarminge juliusmarminge merged commit f29a69f into t3-oss:main May 7, 2024
266 of 267 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: In ./start-database.sh DB_CONTAINER_NAME should be changed
2 participants