feat: Load port from .env fiel in DB scripts #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-falcon
requested review from
juliusmarminge,
nexxeln,
t3dotgg and
c-ehrlich
as code owners
🦋 Changeset detectedLatest commit: cf369d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@victor-falcon is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victor-falcon
force-pushed
the
database-script
branch
from
d9fe4f9
to
d26f286
Compare
I usually change the DB port to avoid conflicts with other projects and being able to run multiple databases at once. With this small change the start-database script loads the expected port from the .env file and spin the container with that port open.
victor-falcon
force-pushed
the
database-script
branch
from
d26f286
to
fab66ea
Compare
juliusmarminge
approved these changes
May 7, 2024
This was referenced May 7, 2024
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app
that referenced
this pull request
Jun 9, 2024
Co-authored-by: Julius Marminge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Changelog
I usually change the DB port to avoid conflicts with other projects and being able to run multiple databases at once. With this small change the start-database script loads the expected port from the .env file and spin the container with that port open.
Screenshots