fix(cli): Only install @trpc/next when router style is page router
#1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inshiku-Han
requested review from
juliusmarminge,
nexxeln,
t3dotgg and
c-ehrlich
as code owners
🦋 Changeset detectedLatest commit: 2b949a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Inshiku-Han is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
juliusmarminge
approved these changes
Apr 22, 2024
|
Tests failing: see for example https://github.com/t3-oss/create-t3-app/actions/runs/8777255115/job/24089822115?pr=1835 |
|
seems like zod 3.23 has changed up some types which has broken t3-env so this pr is unrelated |
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app
that referenced
this pull request
Jun 9, 2024
…3-oss#1835) Co-authored-by: juliusmarminge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
✅ Checklist
Changelog
Only install
@trpc/nextwhen router style is page routerScreenshots
[Screenshots]
💯