fix: non planetscale env.js refers to YOUR_MYSQL_URL_HERE #1802
Conversation
c-ehrlich
requested review from
juliusmarminge,
nexxeln and
t3dotgg
as code owners
🦋 Changeset detectedLatest commit: cef774e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
bot
added
📌 area: cli
cli/src/installers/envVars.ts
Outdated
| if (usingDb) { | ||
| if (usingPlanetScale) { | ||
| if (usingAuth) envFile = "with-auth-db-planetscale.js"; | ||
| else envFile = "with-db-planetscale.js"; | ||
| } else { | ||
| if (usingAuth) envFile = "with-auth-db.js"; | ||
| else envFile = "with-db.js"; | ||
| } | ||
| } |
There was a problem hiding this comment.
dont love this, feel free to suggest something easier to read
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-db-env-refine-t3-oss.vercel.app/ |
| * isn't built with invalid env vars. | ||
| */ | ||
| server: { | ||
| DATABASE_URL: z.string().url(), |
There was a problem hiding this comment.
bit unrelated, but what's your thought on swapping out the url for host, username and password? I tend to prefer that as it's easier to switch between different users but idk if it's just me
There was a problem hiding this comment.
just for planetscale or also for other DBs where this can be possible (i think everything except sqlite?)
There was a problem hiding this comment.
personally if im swapping locally i usually just keep two connection strings in my env file and comment one out. i don't think i would find it more convenient, but not less convenient either. maybe worse for DB providers that only give connection strings so users would have to extract host/user/pw?
dont feel strongly either way, feel free to make the change if you think it's better :)
There was a problem hiding this comment.
Mainly planetscale maybe? Their docs suggests it: 
No need for the ssl query param note then too
Closes #1795
✅ Checklist
💯