Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create url safe db passwords #1799

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix: create url safe db passwords #1799

merged 3 commits into from
Mar 13, 2024

Conversation

tobenna
Copy link
Contributor

@tobenna tobenna commented Mar 13, 2024

Closes #1796

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

openssl rand -base64 12 can create passwords with + and / characters which when used as database urls have to be encoded.
In this modification, I introduced tr '+/' '-_' immediately after the openssl rand -base64 12 command to replace + with - and / with _, making the generated base64 string URL-safe. This ensures that the DB_PASSWORD variable will contain a URL-safe string that can be used directly in database URLs without further encoding.


Screenshots

[Screenshots]

πŸ’―

Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: ba57262

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ 1 unresolved
βœ… 1 resolved
Mar 13, 2024 9:05pm

Copy link

vercel bot commented Mar 13, 2024

@tobenna is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

auto-merge was automatically disabled March 13, 2024 21:04

Head branch was pushed to by a user without write access

@juliusmarminge juliusmarminge merged commit 7579a52 into t3-oss:main Mar 13, 2024
264 of 266 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Start database script doesn't generate url encoded database password
2 participants