Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ESLlint rules for drizzle-orm #1785

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

thecmdrunner
Copy link
Contributor

@thecmdrunner thecmdrunner commented Mar 2, 2024

Closes #1782

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Include Drizzle Lint rules by default
  • Add dynamic installer for eslint
    Previously, we simply renamed the _eslintrc.js file to eslintrc.cjs.
    But to dynamically add rules and plugins based on the user's package selection, we now store the initial config as an object in the code itself, which allows for typesafety!

Screenshots

image
image

πŸ’―

Copy link

changeset-bot bot commented Mar 2, 2024

πŸ¦‹ Changeset detected

Latest commit: fb8d0ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 7, 2024 8:22pm

Copy link

vercel bot commented Mar 2, 2024

@thecmdrunner is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@thecmdrunner thecmdrunner changed the title Feat: Dynamic ESLlint rules (Drizzle ORM) feat: ESLlint rules for drizzle-orm Mar 2, 2024
@thecmdrunner thecmdrunner marked this pull request as ready for review March 3, 2024 10:36
@juliusmarminge juliusmarminge added the πŸš€ autorelease add this label to a pr to trigger a beta release label Mar 7, 2024
@juliusmarminge juliusmarminge added πŸš€ autorelease add this label to a pr to trigger a beta release and removed πŸš€ autorelease add this label to a pr to trigger a beta release labels Mar 7, 2024
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@juliusmarminge juliusmarminge merged commit 57dc6ab into t3-oss:main Mar 7, 2024
266 of 267 checks passed
@thecmdrunner thecmdrunner deleted the feat/drizzle-eslint-rules branch March 8, 2024 09:37
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App πŸš€ autorelease add this label to a pr to trigger a beta release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: ESLint rules for Drizzle ORM
2 participants