Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing default font in pagesDir #1778

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

DerTimonius
Copy link
Contributor

Closes #1743

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

This PR adds the missing default font to the pagesDir. This change made creating separate files for tailwind and native CSS necessary with the related changes to the selectBoilerplate.ts file.

I tested all permutations to get every combination of tailwind, trpc and auth - works as expected!

(Thanks for this awesome project btw!)


πŸ’―

Copy link

changeset-bot bot commented Feb 23, 2024

πŸ¦‹ Changeset detected

Latest commit: ad58d4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 23, 2024 5:44pm

Copy link

vercel bot commented Feb 23, 2024

@DerTimonius is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@juliusmarminge juliusmarminge added this pull request to the merge queue Feb 23, 2024
Merged via the queue into t3-oss:main with commit 01badfb Feb 23, 2024
266 of 267 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Default font doesn't work with Pages Router + Tailwind
2 participants