Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix password substitution in start-database scripts #1764

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

vlxm
Copy link
Contributor

@vlxm vlxm commented Feb 20, 2024

Closes #1761

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

The character # is used as delimiter for the sed expression instead of the default character /, which cannot be used as it may be part of the base64-generated password.


πŸ’―

Copy link

changeset-bot bot commented Feb 20, 2024

πŸ¦‹ Changeset detected

Latest commit: 2e575f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ 1 unresolved
βœ… 1 resolved
Feb 22, 2024 2:52pm

Copy link

vercel bot commented Feb 20, 2024

@vlxm is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix. could you please add a changeset? (pnpm changeset in the project root)

@juliusmarminge juliusmarminge added this pull request to the merge queue Feb 22, 2024
Merged via the queue into t3-oss:main with commit 79e361c Feb 22, 2024
265 of 266 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Co-authored-by: Christopher Ehrlich <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error from sed in start-database.sh
3 participants