Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing pg dev dependency for drizzle-studio #1748

Merged
merged 4 commits into from
Feb 22, 2024
Merged

fix: add missing pg dev dependency for drizzle-studio #1748

merged 4 commits into from
Feb 22, 2024

Conversation

aaronmallen
Copy link
Contributor

resolves #1747

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]

Screenshots

[Screenshots]

💯

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ea3c59a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 4:26pm

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024

@aaronmallen is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the 📌 area: cli Relates to the CLI label Jan 31, 2024
juliusmarminge
juliusmarminge requested changes Feb 1, 2024
View reviewed changes
cli/src/installers/drizzle.ts Outdated Show resolved Hide resolved
@juliusmarminge juliusmarminge changed the title attempt to fix Drizzle postgres dependencies fix: add missing pg dev dependency for drizzle-studio Feb 22, 2024
@juliusmarminge juliusmarminge merged commit 17c2a5e into t3-oss:main Feb 22, 2024
266 of 267 checks passed
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
Merged
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
@aaronmallen @juliusmarminge
fix: add missing pg dev dependency for drizzle-studio (t3-oss#1748)
8876543 
Co-authored-by: juliusmarminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln nexxeln is a code owner

@t3dotgg t3dotgg Awaiting requested review from t3dotgg t3dotgg is a code owner

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich c-ehrlich is a code owner

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Drizzle needs pg
2 participants
@aaronmallen @juliusmarminge