Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add check for yarn 3 #173

Merged
merged 2 commits into from
Jul 11, 2022
Merged

feat: add check for yarn 3 #173

merged 2 commits into from
Jul 11, 2022

Conversation

c-ehrlich
Copy link
Member

Add check for Yarn 3

  • I reviewed linter warnings + errors, resolved formatting, types and other issues related to my work
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

This commit adds a warning when the CLI is run using Yarn 3. This is to alert the users of possible crashes as seen in #57.

I followed the format of #68 as it is a similar issue.

The .yarnrc.yml file is necessary so that the CLI doesn't crash before we can even check whether the user is on yarn 3. See chalk/chalk#531.


Screenshots

(screenshot has a typo in it. i fixed it, but didn't want to create another screenshot as I had already uninstalled yarn 3. Hope that's ok)

Screenshot

@nexxeln
Copy link
Member

nexxeln commented Jul 11, 2022

Thank you.

We don't recommend any package manager, so you can change the message to this.

package manager such as npm, pnpm, or Yarn Classic.

Also can we link that issue in the warning?

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Seems like a lot of people are running Yarn 3 and warning them pushing them onto another pkgManager seems like a good idea.

@nexxeln
Copy link
Member

nexxeln commented Jul 11, 2022

Looks good thank you!

@nexxeln nexxeln merged commit cd846e1 into t3-oss:main Jul 11, 2022
@c-ehrlich c-ehrlich deleted the yarn3-notification branch July 11, 2022 15:16
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* feat: add check for yarn 3

* fix: yarn notification message text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants