Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): reserve height for breadcrumbs on server render #1712

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

ReallyBadNews
Copy link
Contributor

@ReallyBadNews ReallyBadNews commented Dec 28, 2023

Closes #1711

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Move the margin and height to the div wrapping the BreadCrumbs component.


Screenshots

Before:

CleanShot.2023-12-28.at.13.18.56.mp4

After:

CleanShot.2023-12-28.at.13.19.24.mp4

Copy link

changeset-bot bot commented Dec 28, 2023

⚠️ No Changeset found

Latest commit: dbf24b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 28, 2023

@ReallyBadNews is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved
Dec 28, 2023 8:12pm

@juliusmarminge juliusmarminge added this pull request to the merge queue Jan 1, 2024
Merged via the queue into t3-oss:main with commit de8de3a Jan 1, 2024
8 of 9 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(docs): Layout shift caused by client:only Breadcrumbs
2 participants