Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update eslint setup for next 14.0.4 #1703

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Conversation

c-ehrlich
Copy link
Member

@c-ehrlich c-ehrlich commented Dec 20, 2023

Closes #1674

references:
next eslint docs for app router: https://nextjs.org/docs/pages/building-your-application/configuring/eslint
next eslint docs for pages router (important stuff is the same as app dir): https://nextjs.org/docs/app/building-your-application/configuring/eslint

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

πŸ’―

Copy link

changeset-bot bot commented Dec 20, 2023

πŸ¦‹ Changeset detected

Latest commit: 5a01514

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
t3-upgrade βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 28, 2023 3:11pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
create-t3-app ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 3:11pm

@github-actions github-actions bot added πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App labels Dec 20, 2023
Copy link
Contributor

github-actions bot commented Dec 20, 2023

⚑️ Lighthouse report for the changes in this PR:

Category Score
🟒 Performance 99
🟒 Accessibility 91
🟒 Best practices 100
🟒 SEO 100
πŸ”΄ PWA 30

Lighthouse ran on https://create-t3-app-git-eslint-deps-array-t3-oss.vercel.app/

@juliusmarminge juliusmarminge merged commit b6ccded into main Dec 28, 2023
75 checks passed
@juliusmarminge juliusmarminge deleted the eslint-deps-array branch December 28, 2023 15:23
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest ESLint config with @next/eslint-plugin-next doesn't lint dependency arrays
2 participants