Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reuse existing AppRouter type #1687

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

sinasab
Copy link
Contributor

@sinasab sinasab commented Dec 5, 2023

Minor update to reuse existing AppRouter type via import.

Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 2e13855

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 5:34pm

Copy link

vercel bot commented Dec 5, 2023

@sinasab is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I agree with the change. Could you add a proper changeset? (delete the existing changeset file, run pnpm changeset and follow the cli instructions)

@sinasab
Copy link
Contributor Author

sinasab commented Dec 6, 2023

Thanks for the PR. I agree with the change. Could you add a proper changeset? (delete the existing changeset file, run pnpm changeset and follow the cli instructions)

I'm less familiar with changeset so feel free to correct me if I did anything wrong, but it should be good to go now!

Thanks for the review 😁

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@c-ehrlich c-ehrlich added this pull request to the merge queue Dec 6, 2023
Merged via the queue into t3-oss:main with commit 6461090 Dec 6, 2023
74 of 75 checks passed
@sinasab sinasab deleted the patch-1 branch December 6, 2023 21:59
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants