fix: only forward required cookie header #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusmarminge
requested review from
nexxeln,
t3dotgg and
c-ehrlich
as code owners
🦋 Changeset detectedLatest commit: e5136cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
📌 area: cli
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-only-forward-cookie-t3-oss.vercel.app/ |
c-ehrlich
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Looks good! I prefer this version of the fix because it means other headers won't cause similar issues.
Could we get @Allypost credited as a contributor when merging for profiling and submitting the initial solution?
edit: added as a co-author to the commit that added the fix
c-ehrlich
force-pushed
the
only-forward-cookie
branch
from
6d6ef90
to
e5136cc
Compare
github-actions
bot
added
📚 documentation
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
Co-authored-by: Josip Igrec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only really need to forward the header so that tRPC and other stuff can authenticate the user. There are some issues with certain headers that we run into when sending every single header along (I know
transfer-encodingandcontent-lengthare two that doesn't like playing nice)Closes #1640
Closes #1641