Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ⚡ Add /cli change validation to CI workflow #1625

Merged
merged 29 commits into from
Oct 26, 2023

Conversation

Jacksonmills
Copy link
Contributor

@Jacksonmills Jacksonmills commented Oct 25, 2023

Should allow for changes to www and docs to be free from ci errors around changeset, I have little exp working with the ci but thought I would try my attempt at a fix!

Closes #1623

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I pushed a series of commits specifically designed to trigger various edge cases in the GitHub CI workflow, ensuring comprehensive functional testing of the entire process.

Changelog

Added a new step in the CI workflow to check for changes in the /cli directory. If there are any changes, it will validate the changeset by running pnpm changeset status --since origin/next. This ensures that changes made to /cli are properly tracked and validated.

💯⚡

Added a new step in the CI workflow to check for changes in the /cli directory. If there are any changes, it will validate the changeset by running `pnpm changeset status --since origin/next`. This ensures that changes made to /cli are properly tracked and validated.

Should allow for changes to www and docs to be free from ci errors around changeset
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: c90000c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 1:29pm

@vercel
Copy link

vercel bot commented Oct 25, 2023

@Jacksonmills is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@Jacksonmills
Copy link
Contributor Author

image

noice

@c-ehrlich
Copy link
Member

thanks for picking this up! the current version seems to hit false negatives, see #1626

also @juliusmarminge do we also need to include a few files in root such as eslintrc, prettier config, etc? i'm leaning no, because none of them should change the ux of using the cli

@Jacksonmills
Copy link
Contributor Author

thanks for picking this up! the current version seems to hit false negatives, see #1626

also @juliusmarminge do we also need to include a few files in root such as eslintrc, prettier config, etc? i'm leaning no, because none of them should change the ux of using the cli

Ah okay thanks for adding the test PR, I'll see what's going on with that

…ent commit. Also, validate changesets only if changes are made in /cli directory.
@Jacksonmills
Copy link
Contributor Author

Running all the tests ... but it seems the grep command was the culprit, needed to return true if grep doesn't find any matches, allowing the script to proceed to the else block gracefully.

@github-actions github-actions bot removed the 📌 area: cli Relates to the CLI label Oct 26, 2023
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working great now. thanks so much for adding this!

@c-ehrlich c-ehrlich added this pull request to the merge queue Oct 26, 2023
Merged via the queue into t3-oss:next with commit 228be3b Oct 26, 2023
9 of 10 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: ci Relates to CI / GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug (ci): changeset should only be required on changes to cli and outputted app
2 participants