Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show callout when scaffolding with app router #1595

Merged
merged 3 commits into from
Oct 15, 2023
Merged

feat: show callout when scaffolding with app router #1595

merged 3 commits into from
Oct 15, 2023

Conversation

c-ehrlich
Copy link
Member

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b3c69d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-upgrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 10:41pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
create-t3-app ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2023 10:41pm

@github-actions github-actions bot added the 📌 area: cli Relates to the CLI label Oct 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-app-router-warning-t3-oss.vercel.app/

@juliusmarminge juliusmarminge added this pull request to the merge queue Oct 15, 2023
Merged via the queue into next with commit d7824e0 Oct 15, 2023
75 checks passed
@juliusmarminge juliusmarminge deleted the app-router-warning branch October 15, 2023 22:55
@github-actions github-actions bot mentioned this pull request Oct 15, 2023
Merged
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@c-ehrlich
feat: show callout when scaffolding with app router (t3-oss#1595)
28bae27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c-ehrlich @juliusmarminge