Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn if nextauth url and port doesn't match #1591

Closed
wants to merge 1 commit into from
Closed

feat: warn if nextauth url and port doesn't match #1591

wants to merge 1 commit into from

Conversation

juliusmarminge
Copy link
Member

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]

Screenshots

[Screenshots]

💯

@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 10:19pm
t3-upgrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 10:19pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2a4799e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliusmarminge
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 11, 2023
@juliusmarminge juliusmarminge added 🚀 autorelease add this label to a pr to trigger a beta release and removed 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 11, 2023
@github-actions
Copy link
Contributor

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

pnpm create [email protected]

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 11, 2023
@juliusmarminge
Copy link
Member Author

CleanShot 2023-10-11 at 09.18.38@2x.png

juliusmarminge
juliusmarminge commented Oct 11, 2023
View reviewed changes
cli/template/extras/src/env/with-auth-db.mjs
NEXTAUTH_SECRET:
process.env.NODE_ENV === "production"
? z.string()
: z.string().optional(),
NEXTAUTH_URL: z.preprocess(
// This makes Vercel deployments not fail if you don't set NEXTAUTH_URL
// Since NextAuth.js automatically uses the VERCEL_URL if present.
(str) => process.env.VERCEL_URL ?? str,
(str) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is actually the best place to put this, it might continue getting logged more than necessary. an alternative would be putting it in the next config but then we'd need to make a new one for when you choose auth and add this logic there instead. (we're already adding a new one in the appdir pr removing the i18n config stuff)

Copy link
Member

@c-ehrlich c-ehrlich Oct 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintenance burden of adding new files aside, next config feels better to me - here the validation has to run on every request, which seems unnecessary. in next config we could just crash (or log an error, but crashing is harder to ignore) on server start and be done with it.

@juliusmarminge what do you think? is the main reason for having it here that it's not adding more files, or are there other advantages to doing it here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah i think next config is the better choice - put it here purely out of convenience of not having multiple next configs but that's not the best reason 😅

@juliusmarminge juliusmarminge changed the title warn if nextauth url and port doesn't match feat: warn if nextauth url and port doesn't match Oct 15, 2023
@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 15, 2023
@juliusmarminge juliusmarminge force-pushed the 10-11-warn_if_nextauth_url_and_port_doesn_t_match branch from 3f8dc77 to 2a4799e Compare October 15, 2023 22:18
@juliusmarminge juliusmarminge mentioned this pull request Oct 15, 2023
Closed
@juliusmarminge juliusmarminge deleted the 10-11-warn_if_nextauth_url_and_port_doesn_t_match branch November 1, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliusmarminge @c-ehrlich