Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prompts): show correct package manager in prompts #153

Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix(prompts): show correct package manager in prompts #153

merged 1 commit into from
Jul 8, 2022

Conversation

nexxeln
Copy link
Member

@nexxeln nexxeln commented Jul 8, 2022

Used getUserPkgManager function to show correct package manager in the prompts.

  • I reviewed linter warnings + errors, resolved formatting, types and other issues related to my work
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

As discussed in #152

juliusmarminge
juliusmarminge approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@juliusmarminge juliusmarminge merged commit fe66ae9 into main Jul 8, 2022
@juliusmarminge juliusmarminge mentioned this pull request Jul 8, 2022
Closed
@nexxeln nexxeln deleted the fix-install-prompt branch July 9, 2022 07:05
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@nexxeln
fix(prompts): show correct package manager in prompts (t3-oss#153)
5eff315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nexxeln @juliusmarminge