Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduced stylistic linting #1523

Merged

Conversation

JoshuaKGoldberg
Copy link
Contributor

Closes #1520

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Disables @typescript-eslint/array-type and @typescript-eslint/consistent-type-definitions in the template provided to users.


Normally I'd leave a good first issue to someone new, but I'd like to get this in asap.

💯

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2023

🦋 Changeset detected

Latest commit: 0edcad4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 30, 2023

@JoshuaKGoldberg is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 4:48pm

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyyy

I like stylistic rules cause they make for consistent code but I guess users can easily choose to opt in now 🙄

@juliusmarminge juliusmarminge added this pull request to the merge queue Jul 30, 2023
Merged via the queue into t3-oss:next with commit c441a9e Jul 30, 2023
25 of 26 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the reduced-stylistic-linting branch July 30, 2023 19:22
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Disable typescript-eslint's array-type and consistent-type-definitions
2 participants