Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove commit hint when no git repo was initialized #1502

Closed
wants to merge 9 commits into from

Conversation

Mvmo
Copy link
Contributor

@Mvmo Mvmo commented Jul 6, 2023

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

I've passed the noGit Option to the logNextSteps function and depending on that either logged the 'git commit -m "initial commit"' message or not


Screenshots

With git repo

Without git repo

💯

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023

🦋 Changeset detected

Latest commit: 06729e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2023 6:48pm

@vercel
Copy link

vercel bot commented Jul 6, 2023

@Mvmo is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-fork-mvmo-next-t3-oss.vercel.app/

@Mvmo
Copy link
Contributor Author

Mvmo commented Jul 6, 2023

Had some problems with my local dev setup, didn't receive linting errors 😅
Now everything should be according to the style guidelines

@juliusmarminge
Copy link
Member

This is fixing a similar thing as #1507 but will conflict quite a bit.

Will merge 1 and then the other will have to resolve some stuff

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@juliusmarminge
Copy link
Member

Actually don't think we need this after #1507 that prompts you to initialze a git repo if you aren't in one already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants