chore: update prettier and migrate to an esm config #1500

FinnDore · 2023-07-06T06:57:54Z

Closes #1501

✅ Checklist

I have followed every step in the contributing guide (updated 2022-10-06).
The PR title follows the convention we established conventional-commit
I performed a functional test on my final commit

Changelog

Updated prettier and converted the cjs config to esm

Screenshots

[Screenshots]

No screen shot, but a cry for help. each time i install its taking 20mins + ( im still testing my changes )

changeset-bot · 2023-07-06T06:57:57Z

⚠️ No Changeset found

Latest commit: 9e75488

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2023-07-06T06:57:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
create-t3-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 10, 2023 7:52pm

vercel · 2023-07-06T06:58:00Z

@FinnDore is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2023-07-06T06:59:45Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	88
🟢 Accessibility	100
🟢 Best practices	92
🟢 SEO	100
🔴 PWA	30

Lighthouse ran on https://create-t3-app-git-fork-finndore-update-prettier-t3-oss.vercel.app/

cli/template/extras/config/prettier.config.ts

juliusmarminge · 2023-07-06T07:30:55Z

I can't get .ts to work in VSCode (if you also migrate the monorepos config to .ts:

FinnDore · 2023-07-06T07:45:35Z

Looks like this is blocked by tailwindlabs/prettier-plugin-tailwindcss#176

This reverts commit 86a6853.

juliusmarminge · 2023-07-11T16:24:55Z

v0.4.0 includes prettier@3 support

FinnDore · 2023-07-12T06:57:51Z

Will get on it 👍

FinnDore · 2023-07-12T17:32:29Z

withastro/prettier-plugin-astro@94ed904
looks like we need to wait for this to be released aswell....

FinnDore · 2023-08-10T18:51:31Z

Cool, ive tested it again, working as expected, ive also bumped the tailwind plugin

If you wanna make a PR into this branch from that diff we can review them separetely but still merge to main at the same time?

ye, ig the pr will be on my fork

FinnDore · 2023-08-10T18:54:13Z

heres the link.
https://github.com/FinnDore/create-t3-app/pull/1/files

FinnDore · 2023-08-10T18:57:57Z

🥹

chore: applied formatting

github-actions · 2023-08-10T19:01:48Z

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

…t3-app into update-prettier

chore: formatting

FinnDore · 2023-08-10T19:50:06Z

it will take months to recover from this 😔

* updated prettier and config * cjs -> ts * remove require resolve? * Revert "remove require resolve?" This reverts commit 86a6853. * upgraded monorepo * half working now * the state of this plugin * template * version map * trust issues * astro update * format changes * whoops * . * revert ian vs * cli formats it anyways * this fixed it? * . * yes * moved these back to then move them back * moved back * behond confusion * v? * surely this cant hurt * fixed?? * . * 🤡 * move back * cli: rename prettier config * imports * small tweaks * bump eslint-config-prettier version * oh lawd * re-write format functions as --check ---write breaks ivanas eslint stuff * we do a little quote * last formatting * bumped prettier-plugin-tailwindcss 0.4.1 -> 0.5.1 * formatting * we do a little tweak * more tweaking * reverse tweaking * added import thing * begone * :pog: * adjust regexp * formatted the rest of the repo * move config to sub configs --------- Co-authored-by: juliusmarminge <[email protected]>

FinnDore added 2 commits July 6, 2023 09:47

updated prettier and config

fe9d5c9

cjs -> ts

aa3627c

FinnDore requested review from juliusmarminge, nexxeln, t3dotgg and c-ehrlich as code owners July 6, 2023 06:57

github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Jul 6, 2023

vercel bot deployed to Preview – create-t3-app July 6, 2023 06:58 View deployment

juliusmarminge reviewed Jul 6, 2023

View reviewed changes

cli/template/extras/config/prettier.config.ts Outdated Show resolved Hide resolved

cli/template/extras/config/prettier.config.ts Outdated Show resolved Hide resolved

remove require resolve?

86a6853

vercel bot deployed to Preview – create-t3-app July 6, 2023 07:07 View deployment

Revert "remove require resolve?"

5f1507b

This reverts commit 86a6853.

vercel bot deployed to Preview – create-t3-app July 6, 2023 07:46 View deployment

upgraded monorepo

9000fff

vercel bot had a problem deploying to Preview – create-t3-app July 6, 2023 07:56 Failure

github-actions bot added the 📚 documentation Improvements or additions to documentation label Jul 6, 2023

half working now

a913057

vercel bot had a problem deploying to Preview – create-t3-app July 12, 2023 17:39 Failure

the state of this plugin

947b247

vercel bot had a problem deploying to Preview – create-t3-app July 12, 2023 17:41 Failure

formatting

3dca656

juliusmarminge approved these changes Aug 10, 2023

View reviewed changes

Merge pull request #1 from FinnDore/update-prettier-formatting

ae3bb57

chore: applied formatting

vercel bot deployed to Preview – create-t3-app August 10, 2023 19:03 View deployment

FinnDore added 3 commits August 10, 2023 20:07

we do a little tweak

b566416

Merge branch 'update-prettier' of https://github.com/FinnDore/create-…

1737b2f

…t3-app into update-prettier

more tweaking

370c66d

vercel bot deployed to Preview – create-t3-app August 10, 2023 19:10 View deployment

reverse tweaking

9d33660

vercel bot deployed to Preview – create-t3-app August 10, 2023 19:13 View deployment

FinnDore added 3 commits August 10, 2023 20:20

added import thing

685d224

begone

74fbf39

:pog:

05e3c7c

vercel bot deployed to Preview – create-t3-app August 10, 2023 19:32 View deployment

FinnDore added 3 commits August 10, 2023 20:33

adjust regexp

4e9f571

Merge branch 'update-prettier' into update-prettier-formatting

d4030f5

formatted the rest of the repo

336bc67

vercel bot deployed to Preview – create-t3-app August 10, 2023 19:43 View deployment

FinnDore added 3 commits August 10, 2023 20:46

move config to sub configs

b340d3d

Merge branch 'update-prettier' into update-prettier-formatting

59be42e

Merge pull request #2 from FinnDore/update-prettier-formatting

9e75488

chore: formatting

juliusmarminge merged commit ea2a8c6 into t3-oss:next Aug 10, 2023
23 of 24 checks passed

vercel bot deployed to Preview – create-t3-app August 10, 2023 19:52 View deployment

mrienstra mentioned this pull request Sep 3, 2023

feat: add #1500 to changelog / release notes #1551

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update prettier and migrate to an esm config #1500

chore: update prettier and migrate to an esm config #1500

FinnDore commented Jul 6, 2023 •

edited

Loading

changeset-bot bot commented Jul 6, 2023 •

edited

Loading

vercel bot commented Jul 6, 2023 •

edited

Loading

vercel bot commented Jul 6, 2023

github-actions bot commented Jul 6, 2023 •

edited

Loading

juliusmarminge commented Jul 6, 2023

FinnDore commented Jul 6, 2023

juliusmarminge commented Jul 11, 2023

FinnDore commented Jul 12, 2023

FinnDore commented Jul 12, 2023

FinnDore commented Aug 10, 2023 •

edited

Loading

FinnDore commented Aug 10, 2023

FinnDore commented Aug 10, 2023

github-actions bot commented Aug 10, 2023 •

edited

Loading

FinnDore commented Aug 10, 2023

chore: update prettier and migrate to an esm config #1500

chore: update prettier and migrate to an esm config #1500

Conversation

FinnDore commented Jul 6, 2023 • edited Loading

✅ Checklist

Changelog

Screenshots

changeset-bot bot commented Jul 6, 2023 • edited Loading

⚠️ No Changeset found

vercel bot commented Jul 6, 2023 • edited Loading

vercel bot commented Jul 6, 2023

github-actions bot commented Jul 6, 2023 • edited Loading

juliusmarminge commented Jul 6, 2023

FinnDore commented Jul 6, 2023

juliusmarminge commented Jul 11, 2023

FinnDore commented Jul 12, 2023

FinnDore commented Jul 12, 2023

FinnDore commented Aug 10, 2023 • edited Loading

FinnDore commented Aug 10, 2023

FinnDore commented Aug 10, 2023

github-actions bot commented Aug 10, 2023 • edited Loading

FinnDore commented Aug 10, 2023

FinnDore commented Jul 6, 2023 •

edited

Loading

changeset-bot bot commented Jul 6, 2023 •

edited

Loading

vercel bot commented Jul 6, 2023 •

edited

Loading

github-actions bot commented Jul 6, 2023 •

edited

Loading

FinnDore commented Aug 10, 2023 •

edited

Loading

github-actions bot commented Aug 10, 2023 •

edited

Loading