fix: Disallow trailing commas in cli template code to match the generated prettier config #1493
Conversation
dcottr
requested review from
juliusmarminge,
nexxeln,
t3dotgg and
c-ehrlich
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6ed21f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dcottr is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
📌 area: cli
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-fork-dcottr-next-t3-oss.vercel.app/ |
…rettier config (disallow trailing newlines)
|
I feel like this got out of hand in terms of diff size, lmk if the preference is to just allow trailing commas on the generated project (that would make the diff smaller). I assumed the preference is to keep the generated app as simple and with as barebone configs as possible |
There was a problem hiding this comment.
The default should be ES5: https://prettier.io/docs/en/options.html#trailing-commas
…t's changed to es5
Good call thanks, switched it to override to es5 & re-ran prettier. |
…ated prettier config (t3-oss#1493) * fix: Make the prettier config in template consistent with generated prettier config (disallow trailing newlines) * chore: add changeset * For some reason pnpm format didn't catch these * Override trailing commaconfig to the true default value (es5, not none) * chore: Make the changelog describe the change more clearly now that it's changed to es5
Closes #1492
✅ Checklist
Changelog
Screenshots
N/A
💯