Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add spacing between github icon and star bubble icon #1491

Merged
merged 2 commits into from
Jun 26, 2023
Merged

fix: add spacing between github icon and star bubble icon #1491

merged 2 commits into from
Jun 26, 2023

Conversation

Hatzilu
Copy link
Contributor

@Hatzilu Hatzilu commented Jun 26, 2023

Closes #1488

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

added spacing between github icon and star bubble icon


Screenshots

before after
image image

💯

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: 0fea239

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 1:05pm
t3-upgrade 🔄 Building (Inspect) Jun 26, 2023 1:05pm

@vercel
Copy link

vercel bot commented Jun 26, 2023

@Kapeet is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-fork-kapeet-next-t3-oss.vercel.app/

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better, thanks :)

@c-ehrlich c-ehrlich added this pull request to the merge queue Jun 26, 2023
Merged via the queue into t3-oss:next with commit 71ba00c Jun 26, 2023
6 of 7 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* fix: add spacing between github icon and star bubble icon

* fix: add spacing between the github icon and the github star bubble icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: no spacing between github icon and github star in the docs website
2 participants