Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextauth-drizzle): changed varchar to text on drizzle nextauth to prevent auth errors #1486

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

not-ani
Copy link
Contributor

@not-ani not-ani commented Jun 24, 2023

Closes #1485

✅ Checklist

  • [| ] I have followed every step in the contributing guide (updated 2022-10-06).
  • [ |] The PR title follows the convention we established conventional-commit
  • [| ] I performed a functional test on my final commit

Changelog

[Short description of what has changed]
in the nextauth drizzle template I changes varchar to text on some fields to prevent errors when authenticating

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2023

⚠️ No Changeset found

Latest commit: e12193a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2023 5:45pm

@vercel
Copy link

vercel bot commented Jun 24, 2023

@XIFTEN is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-fork-xiften-drizzle-t3-oss.vercel.app/

@c-ehrlich
Copy link
Member

Are there currently errors when authenticating? I checked out the #1461 branch recently and auth worked for me.

@juliusmarminge
Copy link
Member

juliusmarminge commented Jun 27, 2023

255 should be more than enough for tokens? It worked last time I used it

@not-ani
Copy link
Contributor Author

not-ani commented Jun 30, 2023

I'm experiencing the error when using google for auth. It's already a documented issue nextauthjs/next-auth#4734. Can't record the error since I'm out of town and don't have my computer.

@chungweileong94
Copy link
Contributor

chungweileong94 commented Jul 2, 2023

255 should be more than enough for tokens?

Yeah, it was the case before. But having to try it myself and seems like it's no longer the case, at least for Google OAuth.

I might be wrong, but existing users won't face any issues, and it only happens to newly sign-in users.

@juliusmarminge juliusmarminge merged commit f37b9de into t3-oss:drizzle Jul 30, 2023
2 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants