Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reminder to commit after creating app #1482

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

benmarg
Copy link
Contributor

@benmarg benmarg commented Jun 22, 2023

Closes #

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Added a reminder to git commit after creating an application with the CLI


Screenshots

[Screenshots]

πŸ’―

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

πŸ¦‹ Changeset detected

Latest commit: 94cd4ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 22, 2023 8:02am

@vercel
Copy link

vercel bot commented Jun 22, 2023

@benmarg is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

⚑️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 78
🟒 Accessibility 100
🟒 Best practices 100
🟒 SEO 100
πŸ”΄ PWA 30

Lighthouse ran on https://create-t3-app-git-fork-benmarg-addcommitreminder-t3-oss.vercel.app/

@nexxeln nexxeln added this pull request to the merge queue Jun 22, 2023
Merged via the queue into t3-oss:next with commit 338018a Jun 22, 2023
25 of 26 checks passed
@juliusmarminge
Copy link
Member

do we really want this?

not commiting in the CLI was a decision we made cause people should have the ability to pick their own message and when to commit,

adding it as a next step feels like we're enforcing them doing this step which begs the question why does the CLI not do it for them?

@benmarg
Copy link
Contributor Author

benmarg commented Jun 22, 2023

IMO this feels like the best middleground. Committing in the CLI is a bit opinionated like you say, but by doing it this way, the user can still opt to choose whatever name they want(they don't have to copy and paste the next step, they can always just plug in their own commit message).

Including some reminder to commit is important because it's an easy step to forget. How would a first time user of the CLI think to check/know that the CLI stages but doesn't commit for you?

devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* feat: added reminder to commit inital commit

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants