feat: remove possible trailing slash from appName prompt

[brunoeduardodev]

Closes #1460

✅ Checklist

• I have followed every step in the contributing guide (updated 2022-10-06).
• The PR title follows the convention we established conventional-commit
• I performed a functional test on my final commit

---

Changelog

Ignore trailing slashes when prompting the app name

---

Screenshots

When prompting ./

When prompting any path with a trailing slash

💯

[changeset-bot]

🦋 Changeset detected

Latest commit: f2a49bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-t3-app	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
create-t3-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 11, 2023 1:33am

[vercel]

@brunoeduardodev is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	83
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	100
🔴 PWA	30

Lighthouse ran on https://create-t3-app-git-fork-brunoeduardodev-next-t3-oss.vercel.app/

[brunoeduardodev]

I don't fully love this solution since there's a duplicated checking, both on the validate function and after getting the prompt result, do y'all have any suggestions on this?

[brunoeduardodev]

Currently the PR doesn't affect appNames provided by the CLI, the project creation works, but the project name, when passing a trailing slash direct to the CLI results in a empty appName, in this case might make sense doing this validation on parseNameAndPath but I'm not sure if this would be too much, thoughts?

[c-ehrlich]

Currently the PR doesn't affect appNames provided by the CLI, the project creation works, but the project name, when passing a trailing slash direct to the CLI results in a empty appName, in this case might make sense doing this validation on parseNameAndPath but I'm not sure if this would be too much, thoughts?

not sure about implementation details. but in terms of how it works for the user, it should be consistent for:

• typing the app name in response to the prompt
• adding it as an arg to the CLI
• CI (same as above I think?)

[brunoeduardodev]

I've just changed the implementation to remove the trailing space after the initial appName is get, so potential trailing slashes are removed from the prompt, args or ci,

usecase:

./ by args (appName becomes cwd after parsing)

./ by prompt (appName becomes cwd after parsing)

./some/path/ by args (appName becomes "path" after parsing)

./some/path/ by prompt (appName becomes "path" after parsing)

[c-ehrlich]

this looks really clean :)

one remaining issue is that it doesn't catch a name that is just / and thus turned into an empty string, causing the command line to crash (if the user submits an empty string the normal way, their app gets named my_t3_app instead).

this behaviour should definitely be taken care of, but not sure what's better:

• doing the same thing as when an empty string is provided at the start
• turning an app name of / into . as it feels like this might be the user intent (they almost certainly didnt intend to init at the root of their file system)
• an error of some sort

[brunoeduardodev]

I see, currently the create-t3-app gives a validation error when a user prompts /, and when passing / through args it goes to the root dir,

So my suggestion would be keeping this behavior, since there might be some kind of weird scenario where it's wanted to create the app through the root,

this would mean we are going to remove trailing slashes only if there's at least 2 characters, do you have thoughts?

[c-ehrlich]

I see, currently the create-t3-app gives a validation error when a user prompts /, and when passing / through args it goes to the root dir,

So my suggestion would be keeping this behavior, since there might be some kind of weird scenario where it's wanted to create the app through the root,

this would mean we are going to remove trailing slashes only if there's at least 2 characters, do you have thoughts?

Sounds good!

[brunoeduardodev]

Just added a commit adding this behavior, I wonder if we should give a hint to the user telling then to use . if they want to install the project on the current dir.

I've also moved the verification to an util function, not sure if utils folder was the best place for that.

From prompt

From args

[c-ehrlich]

This looks good :) Thanks for the PR!