Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: app router option #1446

Closed
wants to merge 50 commits into from
Closed

feat!: app router option #1446

wants to merge 50 commits into from

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented May 24, 2023 •
edited
Loading

Closes #1364

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]

Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: c1847bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app-nextra ❌ Failed (Inspect) Sep 11, 2023 10:30pm
t3-upgrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 10:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
create-t3-app ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2023 10:30pm

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels May 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-appdir-t3-oss.vercel.app/

@github-actions github-actions bot added the 📌 area: ci Relates to CI / GitHub Actions label May 24, 2023
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label May 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023 •
edited
Loading

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

pnpm create [email protected]

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label May 24, 2023
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Sep 11, 2023
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Sep 11, 2023
@juliusmarminge
Copy link
Member Author

juliusmarminge commented Sep 11, 2023 •
edited
Loading 

pnpm create [email protected]

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Sep 11, 2023
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Sep 11, 2023
@juliusmarminge juliusmarminge mentioned this pull request Sep 13, 2023
Merged
@ajdiyassin
Copy link

Which approach is more recommended? this one with server actions
or #1567 with a proxy approach?

@juliusmarminge
Copy link
Member Author

Which approach is more recommended? this one with server actions
or #1567 with a proxy approach?

the other is less opinionated and doesn't use as many experimental stuff.

@juliusmarminge
Copy link
Member Author

Superseded by #1567 for now. Might revisit this later when some of the experimental stuff is less experimental :)

@jackbisceglia
Copy link

Is there any way to achieve revalidation for trpc based actions in the meantime while this is on the backburner ?

@juliusmarminge juliusmarminge deleted the appdir branch November 1, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📌 area: ci Relates to CI / GitHub Actions 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: experimental appDir option and migration guide