Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(env-variables): update docs to use T3 Env #1384 #1391

Merged
merged 13 commits into from
May 7, 2023
Merged

docs(env-variables): update docs to use T3 Env #1384 #1391

merged 13 commits into from
May 7, 2023

Conversation

esau-morais
Copy link
Contributor

@esau-morais esau-morais commented Apr 28, 2023 •
edited
Loading

Closes #1384

✅ Checklist

Changelog

Rewrite docs for Environment Variables using T3 Env in English and Portuguese (Brazil)

💯

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1f91845

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2023 11:21am

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Apr 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-fork-esau-morais-docs-uset3env-t3-oss.vercel.app/

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2023 •
edited
Loading

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

PT: @minsk-dev, @Sn0wye, @victoriaquasar, @MattFerreira18, @gilhrpenner

@esau-morais
Copy link
Contributor Author

@juliusmarminge, do you mind checking if the "Validation Logic" section is necessary in the CT3 docs? Maybe we should focus everything related to T3 Env on its own docs.

Also, it's been a while since I've written posts/documentation, so I'd be really grateful to have some critical feedback about my writing

Sn0wye
Sn0wye suggested changes May 2, 2023
View reviewed changes
Copy link
Contributor

@Sn0wye Sn0wye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice writing throughout the whole file, but I'd suggest to maintain the env.ts file as env.mjs, since it runs before the compilation time, it cannot be Typescript.

www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Show resolved Hide resolved
www/src/pages/pt/usage/env-variables.mdx Outdated Show resolved Hide resolved
@esau-morais esau-morais marked this pull request as ready for review May 3, 2023 19:03
@vercel
Copy link

vercel bot commented May 3, 2023

@esau-morais is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Sn0wye
Sn0wye approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@Sn0wye Sn0wye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

juliusmarminge
juliusmarminge requested changes May 7, 2023
View reviewed changes
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - small nits

www/src/pages/en/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/en/usage/env-variables.mdx Outdated Show resolved Hide resolved
www/src/pages/en/usage/env-variables.mdx Show resolved Hide resolved
@juliusmarminge juliusmarminge merged commit 5cef63a into t3-oss:next May 7, 2023
7 of 8 checks passed
joachimjusth added a commit to joachimjusth/create-t3-app that referenced this pull request May 8, 2023
@joachimjusth
docs: update french translation with t3-oss#1162 t3-oss#1391 t3-oss#1338
96b0516
joachimjusth added a commit to joachimjusth/create-t3-app that referenced this pull request May 8, 2023
@joachimjusth
docs: update french translation with t3-oss#1162 t3-oss#1391 t3-oss#1338
b1dc1ef
joachimjusth added a commit to joachimjusth/create-t3-app that referenced this pull request May 8, 2023
@joachimjusth
docs: update french translation with t3-oss#1162 t3-oss#1391 t3-oss#1338
2508266 
 t3-oss#1350
@joachimjusth joachimjusth mentioned this pull request May 8, 2023
Merged
3 tasks
juliusmarminge pushed a commit that referenced this pull request May 9, 2023
@joachimjusth
docs: update french translation with #1162 #1391 #1338 #1350 (#1410)
e76acd0
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@esau-morais @juliusmarminge
docs(env-variables): update docs to use T3 Env t3-oss#1384 (t3-oss#1391)
b59751f 
* docs(env-variables): update docs to use T3 Env t3-oss#1384

* docs: add pt-BR translation for env-variables

* docs(changeset): add missing changeset

* fix: remove old reference to `processEnv`

* docs: add missing `runtimeEnv`

* docs: update all wrong `env.mjs` instances

* docs: fix typo in pt-BR translation

* docs: prevent double instance and specify `runtimeEnv` option as required

* Delete hip-eagles-deny.md

* Delete nice-yaks-push.md

* fix

---------

Co-authored-by: Julius Marminge <[email protected]>
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@joachimjusth
docs: update french translation with t3-oss#1162 t3-oss#1391 t3-oss#1338
f0a5192 
 t3-oss#1350 (t3-oss#1410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@Sn0wye Sn0wye Sn0wye approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: rewrite env-variables docs page to use/reference new package
3 participants
@esau-morais @juliusmarminge @Sn0wye