Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to t3-env #1377

Merged
merged 7 commits into from
Apr 27, 2023
Merged

refactor: migrate to t3-env #1377

merged 7 commits into from
Apr 27, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Apr 23, 2023

🤫

Tests

Edge

CleanShot 2023-04-24 at 00 20 03

Lambda

CleanShot 2023-04-24 at 00 20 24

Client

CleanShot 2023-04-24 at 00 21 03

CleanShot 2023-04-24 at 00 21 22

Starting dev / build

CleanShot 2023-04-24 at 00 22 21

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023

🦋 Changeset detected

Latest commit: af98be9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 8:47pm

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Apr 23, 2023
@juliusmarminge juliusmarminge added 🚀 autorelease add this label to a pr to trigger a beta release 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App and removed 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Apr 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-t3-env-t3-oss.vercel.app/

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2023

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

pnpm create [email protected]

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Apr 23, 2023
@github-actions github-actions bot added the 📌 area: ci Relates to CI / GitHub Actions label Apr 23, 2023
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Apr 23, 2023
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Apr 23, 2023
@c-ehrlich
Copy link
Member

works in docker... ie it still respects SKIP_ENV_VALIDATION

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Apr 25, 2023
@juliusmarminge juliusmarminge changed the title refactor: use package for env refactor: migrate to t3-env Apr 25, 2023
@juliusmarminge juliusmarminge marked this pull request as ready for review April 25, 2023 22:32
cli/template/base/tsconfig.json Outdated Show resolved Hide resolved
cli/package.json Outdated Show resolved Hide resolved
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@c-ehrlich c-ehrlich added this pull request to the merge queue Apr 27, 2023
Merged via the queue into next with commit 00018ff Apr 27, 2023
@c-ehrlich c-ehrlich deleted the t3-env branch April 27, 2023 20:57
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* use pacakge for env

* fix script versioning

* whoops

* add a callout in docs

* fixies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: ci Relates to CI / GitHub Actions 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants