Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enforce NEXT_PUBLIC_ env key on client with TS #1370

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

chungweileong94
Copy link
Contributor

Closes #1369

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Enforce NEXT_PUBLIC_ env key on client, using other non-NEXT_PUBLIC_ key on client will give you a type error.


Screenshots

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023

🦋 Changeset detected

Latest commit: 3e02e28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 3:45pm

@github-actions
Copy link
Contributor

Running Lighthouse audit...

@chungweileong94 chungweileong94 changed the title Enforce NEXT_PUBLIC_ env key on client with TS feat: Enforce NEXT_PUBLIC_ env key on client with TS Apr 20, 2023
cli/template/base/src/env.mjs Outdated Show resolved Hide resolved
@juliusmarminge juliusmarminge added this pull request to the merge queue Apr 20, 2023
Merged via the queue into t3-oss:next with commit 18bc6a7 Apr 20, 2023
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* feat: Enforce `NEXT_PUBLIC_` env key on client

* chore: add changeset

* fix: Remove @ts-check

* fix: Revert code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: EnforceNEXT_PUBLIC_ env key on client
3 participants