Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): remove unnecessary type casts #1326

Merged
merged 1 commit into from
Apr 2, 2023
Merged

feat(docs): remove unnecessary type casts #1326

merged 1 commit into from
Apr 2, 2023

Conversation

PiotrekPKP
Copy link
Contributor

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • removed type casts from sidebar array using spread which makes TS happy
  • removed Entry type and used inference instead
  • added OuterHeaders return type to make sure function returns correct value

πŸ’―

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2023

⚠️ No Changeset found

Latest commit: 12872f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the πŸ“š documentation Improvements or additions to documentation label Apr 2, 2023
@vercel
Copy link

vercel bot commented Apr 2, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 2, 2023 11:55am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

Running Lighthouse audit...

@juliusmarminge juliusmarminge added this pull request to the merge queue Apr 2, 2023
Merged via the queue into t3-oss:next with commit d00a003 Apr 2, 2023
@PiotrekPKP PiotrekPKP deleted the fix-sidebar-types branch April 3, 2023 04:25
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“š documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants