Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update types for global prisma instance #1321

Merged
merged 4 commits into from
Apr 1, 2023
Merged

Conversation

JingLi1998
Copy link
Contributor

Closes #1320

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Add undefined to global type definition.

Replace || with ??


Screenshots

πŸ’―

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2023

πŸ¦‹ Changeset detected

Latest commit: 596916f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 1, 2023 4:58am

@github-actions github-actions bot added πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App labels Apr 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

Running Lighthouse audit...

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks :)

@c-ehrlich c-ehrlich added this pull request to the merge queue Apr 1, 2023
Merged via the queue into t3-oss:next with commit 7fcb41c Apr 1, 2023
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* fix: update types for global prisma instance

* chore: add changeset

---------

Co-authored-by: Jing Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Global prisma instance type is slightly incorrect
3 participants