Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git prompt #130

Merged
merged 9 commits into from
Jul 8, 2022
Merged

feat: add git prompt #130

merged 9 commits into from
Jul 8, 2022

Conversation

Alexanderdunlop
Copy link
Contributor

@Alexanderdunlop Alexanderdunlop commented Jul 6, 2022

Add git prompt

  • I reviewed linter warnings + errors, resolved formatting, types and other issues related to my work
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit
  • Simple confirm
  • Redirect PR to main

In #128 @juliusmarminge suggested adding a git init prompt to choose if you wish to init a git repo.
Skips if noGit flag is already passed.


Screenshots

image

image

💯

Fedeorlandau and others added 4 commits July 6, 2022 00:11
* Moved where the node18 warning shows up

Also adjusted the default install if people have node18 installed

Readded the --version flag

* Using the consts.TITLE_TEXT inside renderTitle func
src/cli/index.ts Outdated Show resolved Hide resolved
@juliusmarminge
Copy link
Member

Also point the PR to main

@Alexanderdunlop
Copy link
Contributor Author

Hey @juliusmarminge thanks for the comments, first time doing an open source PR.
Will work on all these changes after work.
Thanks for bearing with me 😄

@Alexanderdunlop Alexanderdunlop changed the base branch from dev to main July 8, 2022 03:05
@Alexanderdunlop
Copy link
Contributor Author

Alexanderdunlop commented Jul 8, 2022

@juliusmarminge updated PR to main, also fixed requested changes (added related message)

Changed PR via the edit tool hope this didn't cause issues

image

@juliusmarminge
Copy link
Member

Not sure why husky isnt formatting precommit for you?

@Alexanderdunlop
Copy link
Contributor Author

Alexanderdunlop commented Jul 8, 2022

Was able to fix was because of this:

image

My bad for that, it won't happen again.

Had a bad commit because the format change was slightly different (removing a line) which husky didn't like

@juliusmarminge
Copy link
Member

All good. Thats why we added the CI to get the verification before merge. Every commit doesnt have to be perfect ☺️

@Alexanderdunlop
Copy link
Contributor Author

Alexanderdunlop commented Jul 8, 2022

Thanks for being understanding! Wasn't a lot of code but this my first non readme PR to open source.
Hope I can help out more in the future!

Updated PR to match template format.

@juliusmarminge should I resolve a conversation or leave that to the maintainers?

@juliusmarminge juliusmarminge merged commit e5be271 into t3-oss:main Jul 8, 2022
@Alexanderdunlop Alexanderdunlop deleted the git-prompt branch July 8, 2022 11:46
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants