feat: Replace Git Bash check with Mintty check #1295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1281
✅ Checklist
Changelog
Replaced the Git Bash check if a check for Mintty. Git Bash works perfectly fine when using another terminal. Mintty is the issue here and it causes lots of issues with other CLI programs.
Not too sure if we want two messages here, I think having a notice specific to Git Bash is needed as it is mainly Git Bash users who are having this issue (Since Git Bash uses Mintty by default).
Screenshots
WSL VSC (Should not be affected by the change)
![image](https://user-images.githubusercontent.com/31937542/227657521-a57dc0f7-932f-40c9-a5de-8d8b55aa9c7f.png)
Git Bash + Mintty
![image](https://user-images.githubusercontent.com/31937542/227658165-76102845-9930-4af2-9b9a-85e746470abf.png)
Git Bash + Windows Terminal
![image](https://user-images.githubusercontent.com/31937542/227658498-72dd6170-3a58-41ce-8e4e-24ac109895ed.png)
💯