Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace Git Bash check with Mintty check #1295

Merged
merged 5 commits into from
Mar 26, 2023
Merged

feat: Replace Git Bash check with Mintty check #1295

merged 5 commits into from
Mar 26, 2023

Conversation

iAverages
Copy link
Contributor

Closes #1281

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Replaced the Git Bash check if a check for Mintty. Git Bash works perfectly fine when using another terminal. Mintty is the issue here and it causes lots of issues with other CLI programs.

Not too sure if we want two messages here, I think having a notice specific to Git Bash is needed as it is mainly Git Bash users who are having this issue (Since Git Bash uses Mintty by default).


Screenshots

WSL VSC (Should not be affected by the change)
image

Git Bash + Mintty
image

Git Bash + Windows Terminal
image

💯

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

🦋 Changeset detected

Latest commit: f404347

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 5:36PM (UTC)

@github-actions
Copy link
Contributor

Running Lighthouse audit...

@juliusmarminge
Copy link
Member

Can you test this on windows @nexxeln

@nexxeln
Copy link
Member

nexxeln commented Mar 25, 2023

Works! I'm not sure about the two warnings though.

@iAverages
Copy link
Contributor Author

Yea I don’t like the two warnings however I feel like we would get lots of questions about Git Bash not working (with mintty). since mintty is installed by default with Git Bash. I can remove the second warning and potentially change the first message though not sure what the best option is.

cli/src/cli/index.ts Outdated Show resolved Hide resolved
@juliusmarminge juliusmarminge added this pull request to the merge queue Mar 26, 2023
Merged via the queue into t3-oss:next with commit d0a8143 Mar 26, 2023
@iAverages iAverages deleted the feat/mitty branch March 26, 2023 13:42
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* Replace gitbash check with mintty check

* Fix spacing of message

* Add changeset

* Change warning message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Terminal is detected incorrectly on windows terminal running Git-Bash
4 participants