feat: ignore vars that start with _ for eslint no-unused-vars ignore
#1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-ehrlich
requested review from
juliusmarminge,
nexxeln and
t3dotgg
as code owners
🦋 Changeset detectedLatest commit: f1f452c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
📌 area: cli
|
Running Lighthouse audit... |
juliusmarminge
approved these changes
Mar 9, 2023
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
t3-oss#1268) * ignore unused vars that begin with underscore * changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
✅ Checklist
Changelog
Reason for this change is that currently templates that don't do anything with args in createContext (ie any without next-auth) throw an eslint warning. Also using
_as "i'm not using this" is a common enough pattern that I think it's worth allowing by default.see: https://discord.com/channels/966627436387266600/1081204127327059998
💯