Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add validation for import aliases #1255

Merged
merged 6 commits into from
Mar 3, 2023
Merged

Conversation

justasam
Copy link
Contributor

@justasam justasam commented Feb 28, 2023

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Add validation for import aliases

Screenshots

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

🦋 Changeset detected

Latest commit: 6b0539d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 1, 2023 at 9:00PM (UTC)

@github-actions
Copy link
Contributor

Running Lighthouse audit...

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the validate prop instead of calling the prompter multipel times, see promptAppName

@justasam justasam changed the title feat: Disable invalid path aliases feat: Add validation for path aliases Mar 1, 2023
@justasam justasam changed the title feat: Add validation for path aliases feat: Add validation for import aliases Mar 1, 2023
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for the contribution!

@juliusmarminge juliusmarminge added this pull request to the merge queue Mar 3, 2023
Merged via the queue into t3-oss:next with commit 601cbb2 Mar 3, 2023
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
* feat: do not allow invalid import aliases

* chore: add changeset

* fix: use validate instead of custom logic

* fix: update changeset to better match changes

* refactor: change naming from path alias to import alias

---------

Co-authored-by: Christopher Ehrlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants