Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure .eslint.cjs is included in git #1252

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Conversation

ggrochow
Copy link
Contributor

Closes #1251

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Moved the renaming of the _eslint.cjs file to before the git initialization to ensure the file is included by default.


Screenshots

Repo with what will be output and included in git by default.
Options: Typescript, no packages, yes initialize git, yes npm install, default import alias.
ran git commit without any other changes made

https://github.com/ggrochow/create-t3-example

πŸ’―

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

πŸ¦‹ Changeset detected

Latest commit: c94e479

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 28, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Feb 28, 2023 at 8:56PM (UTC)

@github-actions
Copy link
Contributor

Running Lighthouse audit...

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@c-ehrlich c-ehrlich added this pull request to the merge queue Feb 28, 2023
Merged via the queue into t3-oss:next with commit d8be181 Feb 28, 2023
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* fix: ensure .eslint.cjs is included in git

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: eslintrc.cjs is untracked in git when initlizing a repo
2 participants