Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bind configs to variables before exporting to make sure typeerrors are reported #1232

Merged
merged 5 commits into from
Feb 27, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Feb 21, 2023

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Errors weren't reported when they were exported immediately:

CleanShot 2023-02-21 at 10 30 56@2x

Binding it to a variable before exporting fixes it


Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2023

🦋 Changeset detected

Latest commit: fd85f09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 6:20PM (UTC)

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation labels Feb 21, 2023
@github-actions
Copy link
Contributor

Running Lighthouse audit...

@juliusmarminge
Copy link
Member Author

@nexxeln @c-ehrlich approval please

@juliusmarminge juliusmarminge added this pull request to the merge queue Feb 27, 2023
Merged via the queue into next with commit 9c82f86 Feb 27, 2023
@juliusmarminge juliusmarminge deleted the bind-configs branch February 27, 2023 19:30
@c-ehrlich c-ehrlich mentioned this pull request Mar 7, 2023
3 tasks
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
…rs are reported (t3-oss#1232)

* bind configs

* Create odd-spies-appear.md

* Update .changeset/odd-spies-appear.md

---------

Co-authored-by: Christopher Ehrlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants