Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added dynamic lang code to navigation links #1229

Merged
merged 3 commits into from
Feb 21, 2023
Merged

fix: Added dynamic lang code to navigation links #1229

merged 3 commits into from
Feb 21, 2023

Conversation

arielconti10
Copy link
Contributor

Closes #1228

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Added the lang code var to the array of links used in the navbar

Screenshots

Kapture.2023-02-20.at.19.40.53.mp4

💯

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f41bff3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 20, 2023 at 10:55PM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Feb 20, 2023
@github-actions
Copy link
Contributor

Running Lighthouse audit...

@arielconti10 arielconti10 changed the title Fix: Added dynamic lang code to navigation links fix: Added dynamic lang code to navigation links Feb 20, 2023
c-ehrlich
c-ehrlich previously requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Thanks for catching and fixing this!

Despite the CI telling you otherwise, contributions to the site don't require a changeset. Could you remove it? Sorry about this, we'll hopefully have the CI sorted out soon 😅

@arielconti10
Copy link
Contributor Author

Code looks good. Thanks for catching and fixing this!

Despite the CI telling you otherwise, contributions to the site don't require a changeset. Could you remove it? Sorry about this, we'll hopefully have the CI sorted out soon 😅

That's alright, I'll remove it

vinihvc
vinihvc approved these changes Feb 20, 2023
View reviewed changes
Copy link

@vinihvc vinihvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juliusmarminge juliusmarminge added this pull request to the merge queue Feb 21, 2023
Merged via the queue into t3-oss:next with commit 9046c1b Feb 21, 2023
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@arielconti10
fix: Added dynamic lang code to navigation links (t3-oss#1229)
ae212a4 
* fix: Add langCode to href property

* chore: add changeset

* chore: remove changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinihvc vinihvc vinihvc approved these changes

@scrlkx scrlkx scrlkx approved these changes

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Lang code on navigation subpath prefixed to "en"
5 participants
@arielconti10 @c-ehrlich @vinihvc @scrlkx @juliusmarminge