Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treat git bash as un-interactive #1222

Merged
merged 4 commits into from
Feb 19, 2023
Merged

fix: treat git bash as un-interactive #1222

merged 4 commits into from
Feb 19, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Feb 19, 2023 •
edited
Loading

Closes #1139

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]

Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 33cd668

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 19, 2023 at 6:02PM (UTC)

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Feb 19, 2023
@github-actions github-actions bot added the 📌 area: cli Relates to the CLI label Feb 19, 2023
@github-actions
Copy link
Contributor

Running Lighthouse audit...

@github-actions
Copy link
Contributor

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

pnpm create [email protected]

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Feb 19, 2023
@juliusmarminge
Copy link
Member Author

CleanShot 2023-02-19 at 18 54 36

CleanShot 2023-02-19 at 18 52 38

nexxeln
nexxeln approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

@juliusmarminge juliusmarminge marked this pull request as ready for review February 19, 2023 18:02
@juliusmarminge juliusmarminge added this pull request to the merge queue Feb 19, 2023
Merged via the queue into next with commit 7baa339 Feb 19, 2023
@juliusmarminge juliusmarminge deleted the catch-git-bash branch February 19, 2023 18:06
@github-actions github-actions bot mentioned this pull request Feb 19, 2023
Merged
@Zamiell
Copy link
Contributor

Zamiell commented Feb 19, 2023

perfect, thanks julius!

@luisvinicius09 luisvinicius09 mentioned this pull request Mar 20, 2023
Closed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@juliusmarminge
fix: treat git bash as un-interactive (t3-oss#1222)
450ef27 
* handle git bash

* better message

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nexxeln nexxeln nexxeln approved these changes

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: does not work on Git Bash
3 participants
@juliusmarminge @Zamiell @nexxeln