Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make type-imports autofixable & general project cleanup #1217

Merged
merged 25 commits into from
Feb 19, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Feb 18, 2023

Closes #1173
Closes #1163 (disabled cache job - not optimal but not the end of the world, can make a separate package if we really want it cached)
Closes #1182
Closes #1181

โœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Ended up being a bit of everything pr ๐Ÿ˜ฎโ€๐Ÿ’จ

  • fixes some linting, formatting, stylistic changes

[Short description of what has changed]

CleanShot.2023-02-18.at.22.22.54.mp4

Screenshots

[Screenshots]

๐Ÿ’ฏ

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2023

๐Ÿฆ‹ Changeset detected

Latest commit: 64daf93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 18, 2023

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated
create-t3-app โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add your feedback Feb 19, 2023 at 10:58AM (UTC)

@github-actions github-actions bot added ๐Ÿ“Œ area: cli Relates to the CLI ๐Ÿ“š documentation Improvements or additions to documentation labels Feb 18, 2023
@github-actions
Copy link
Contributor

Running Lighthouse audit...

@c-ehrlich
Copy link
Member

we currently use import type { foo } from "bar" in some places and import { type foo } from "bar" in others

is it worth making that consistent?

@juliusmarminge
Copy link
Member Author

we currently use import type { foo } from "bar" in some places and import { type foo } from "bar" in others

is it worth making that consistent?

probably - this lint rule is gonna prefer the inline one but it doesn't complain about the other way. maybe there is a way to do that ๐Ÿค”

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2023

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes โค๏ธ.

@github-actions github-actions bot added the ๐Ÿ“Œ area: t3-app Relates to the generated T3 App label Feb 19, 2023
@juliusmarminge
Copy link
Member Author

we currently use import type { foo } from "bar" in some places and import { type foo } from "bar" in others

is it worth making that consistent?

Done using this rule: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.md

@juliusmarminge juliusmarminge changed the title fix: make type-imports autofixable fix: make type-imports autofixable & general project cleanup Feb 19, 2023
@juliusmarminge juliusmarminge merged commit 55c87af into next Feb 19, 2023
@juliusmarminge juliusmarminge deleted the autofix-linter branch February 19, 2023 10:59
juliusmarminge referenced this pull request Feb 19, 2023
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ“Œ area: ci Relates to CI / GitHub Actions ๐Ÿ“Œ area: cli Relates to the CLI ๐Ÿ“Œ area: t3-app Relates to the generated T3 App ๐Ÿ“š documentation Improvements or additions to documentation
Projects
None yet
2 participants