Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ts-ignores on env.mjs #1189

Merged
merged 4 commits into from
Feb 15, 2023
Merged

fix: remove ts-ignores on env.mjs #1189

merged 4 commits into from
Feb 15, 2023

Conversation

p13lgst
Copy link
Contributor

@p13lgst p13lgst commented Feb 9, 2023

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Fix JSDoc types on env.mjs removing ts-ignores

💯

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023

🦋 Changeset detected

Latest commit: 4962d92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 10:45PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 73
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 93
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-p13lgst-next-t3-oss.vercel.app/

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I like it!

We need to do it for all the other files too though

cli/template/base/src/env.mjs Show resolved Hide resolved
@bai
Copy link
Contributor

bai commented Feb 13, 2023

This is badass ✨ Thanks for contributing!

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me how it is now, but would like a 2nd approval from @juliusmarminge before merging

@juliusmarminge juliusmarminge added this pull request to the merge queue Feb 15, 2023
Merged via the queue into t3-oss:next with commit bf12635 Feb 15, 2023
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* fix: remove ts-ignores on env.mjs

* Fix ts-ignores in all other env.mjs

* Create gold-berries-happen.md

---------

Co-authored-by: Julius Marminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants