Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): exit with error code when aborting installation #1043

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Jan 3, 2023

Closes #1033
Closes #1029

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Exits with error code if aborted

    CleanShot 2023-01-03 at 10 16 33@2x
  • Removed log <dirname> exists but is empty, continuing... if scaffolded in current directory.

    CleanShot 2023-01-03 at 10 14 11@2x

Screenshots

[Screenshots]

πŸ’―

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Updated
create-t3-app ⬜️ Ignored (Inspect) Jan 3, 2023 at 9:18AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2023

πŸ¦‹ Changeset detected

Latest commit: 7c6ba45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliusmarminge juliusmarminge changed the title fix error codes and . name fix: error codes and . name Jan 3, 2023
@github-actions github-actions bot added the πŸ“Œ area: cli Relates to the CLI label Jan 3, 2023
@juliusmarminge juliusmarminge changed the title fix: error codes and . name fix(cli): exit with error code when aborting installation Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

⚑️ Lighthouse report for the changes in this PR:

Category Score
🟒 Performance 98
🟒 Accessibility 100
🟒 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-julius-error-code2-t3-oss.vercel.app/

@juliusmarminge juliusmarminge added the πŸš€ autorelease add this label to a pr to trigger a beta release label Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

pnpm create [email protected]

@github-actions github-actions bot removed the πŸš€ autorelease add this label to a pr to trigger a beta release label Jan 3, 2023
@juliusmarminge juliusmarminge added the πŸš€ autorelease add this label to a pr to trigger a beta release label Jan 3, 2023
@github-actions github-actions bot removed the πŸš€ autorelease add this label to a pr to trigger a beta release label Jan 3, 2023
@c-ehrlich c-ehrlich merged commit 6fe7e1e into next Jan 3, 2023
@c-ehrlich c-ehrlich deleted the julius/error-code2 branch January 3, 2023 09:56
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* fix error codes and . name

* move if

* Create green-laws-hammer.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect exit codes on failure feat: informational message improvements
2 participants