Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(template): add @types/prettier package to tailwind installer #1010

Merged
merged 5 commits into from
Dec 26, 2022

Conversation

maxmellen
Copy link
Contributor

Closes #1009

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

@types/prettier is now added as a dependency to the project when the Tailwind addon is selected, this ensures auto-completion in the Prettier config file in VS Code after a fresh project init.


Screenshots

截圖 2022-12-26 12 08 36

💯

@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2022

🦋 Changeset detected

Latest commit: 5fa3d3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Dec 26, 2022 at 2:54PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-maxmellen-patch-1-t3-oss.vercel.app/

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, we could also do it in json form and get Intellisense without an additional package - although the types-package showing default value and proper types are better imo

{
  "$schema": "http:https://json.schemastore.org/prettierrc",
  "plugins": ["prettier-plugin-tailwindcss"]
}

cli/src/installers/index.ts Outdated Show resolved Hide resolved
@juliusmarminge juliusmarminge enabled auto-merge (squash) December 26, 2022 14:55
@juliusmarminge juliusmarminge merged commit 9eddbab into t3-oss:next Dec 26, 2022
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
…3-oss#1010)

* chore(template): add @types/prettier package to tailwind installer

* Update cli/src/installers/index.ts

* Create proud-rabbits-film.md

* Update cli/src/installers/index.ts

Co-authored-by: Julius Marminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(template): add @types/prettier package to tailwind installer
2 participants